Thread (4 messages) 4 messages, 2 authors, 2019-07-10

Re: [PATCH v2 2/3] ata: make qc_prep return an int

From: Jens Axboe <axboe@kernel.dk>
Date: 2019-07-10 03:04:15
Also in: lkml

On 7/9/19 4:02 AM, Jiri Slaby wrote:
In case a driver wants to return an error. sata_mv is one of those --
see the next patch.
Not against the change as such, but there seems to be some confusion on
int vs enum ata_completion_errors. The latter is probably poorly named
if you're going to start using it for prep return, but would probably
still be saner to have an AC_ERR_OK as 0 and use that and use the enum.

-- 
Jens Axboe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help