Thread (33 messages) 33 messages, 4 authors, 2019-05-28

Re: [PATCH 03/16] lib,treewide: add new match_string() helper/macro

From: Ardelean, Alexandru <hidden>
Date: 2019-05-08 13:22:21
Also in: alsa-devel, cgroups, dri-devel, intel-gfx, kvm, linux-arm-kernel, linux-clk, linux-fbdev, linux-gpio, linux-integrity, linux-mm, linux-mmc, linux-omap, linux-pci, linux-pm, linux-rockchip, linux-security-module, linux-tegra, linux-usb, linux-wireless, linuxppc-dev, lkml, netdev

On Wed, 2019-05-08 at 15:18 +0200, Greg KH wrote:

On Wed, May 08, 2019 at 04:11:28PM +0300, Andy Shevchenko wrote:
quoted
On Wed, May 08, 2019 at 02:28:29PM +0300, Alexandru Ardelean wrote:
quoted
This change re-introduces `match_string()` as a macro that uses
ARRAY_SIZE() to compute the size of the array.
The macro is added in all the places that do
`match_string(_a, ARRAY_SIZE(_a), s)`, since the change is pretty
straightforward.
Can you split include/linux/ change from the rest?
That would break the build, why do you want it split out?  This makes
sense all as a single patch to me.
Not really.
It would be just be the new match_string() helper/macro in a new commit.
And the conversions of the simple users of match_string() (the ones using
ARRAY_SIZE()) in another commit.

Thanks
Alex
thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help