Re: [PATCH] block: fix CDROM dependency on BLK_DEV
From: Bart Van Assche <hidden>
Date: 2017-11-02 14:59:48
Also in:
linux-scsi, lkml
Subsystem:
block layer, the rest · Maintainers:
Jens Axboe, Linus Torvalds
On Thu, 2017-11-02 at 12:19 +0100, Arnd Bergmann wrote:
After the cdrom cleanup, I get randconfig warnings for some configurations: warning: (BLK_DEV_IDECD && BLK_DEV_SR) selects CDROM which has unmet direct dependencies (BLK_DEV)
Hello Arnd, Since Jens has already queued your patch it's too late to consider alternatives. Anyway, since the cdrom driver calls block layer functions directly, have you considered the following alternative?
diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
index 0dad1d2536f7..e7044c893817 100644
--- a/drivers/block/Kconfig
+++ b/drivers/block/Kconfig@@ -69,6 +69,7 @@ config AMIGA_Z2RAM config CDROM tristate "CD-ROM driver" + depends on BLK_DEV help A CD-ROM is a pre-pressed optical compact disc which contains data. The name is an acronym which stands for "Compact Disc