Re: [PATCH 08/11] ata: Drop unnecessary static

Linus Walleij · 2017-08-02T10:23:00+0200

On Sat, Jul 15, 2017 at 10:07 PM, Julia Lawall wrote: > Drop static on a local variable, when the variable is initialized before > any possible use. Thus, the static has no benefit. > > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // > @bad exists@ > position p; > identifier x; > type T; > @@ > static T x@p; > ... > x = > > @@ > identifier x; > expression e; > type T; > position p != bad.p; > @@ > -static > T x@p; > ... when != x > when strict > ?x = e; > // > > Signed-off-by: Julia Lawall Acked-by: Linus Walleij Yours, Linus Walleij

[PATCH 00/11] Drop unnecessary static · Julia Lawall <hidden> · 2017-07-15
[PATCH 08/11] ata: Drop unnecessary static · Julia Lawall <hidden> · 2017-07-15
Re: [PATCH 08/11] ata: Drop unnecessary static · Linus Walleij <hidden> · 2017-08-02
Re: [PATCH 08/11] ata: Drop unnecessary static · Tejun Heo <tj@kernel.org> · 2017-08-02
Re: [PATCH 00/11] Drop unnecessary static · Joe Perches <joe@perches.com> · 2017-07-15
Re: [PATCH 00/11] Drop unnecessary static · Julia Lawall <hidden> · 2017-07-15

From: Linus Walleij <hidden>
Date: 2017-08-02 08:23:04
Also in: kernel-janitors, lkml

On Sat, Jul 15, 2017 at 10:07 PM, Julia Lawall [off-list ref] wrote:

Drop static on a local variable, when the variable is initialized before
any possible use.  Thus, the static has no benefit.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@bad exists@
position p;
identifier x;
type T;
@@
static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@
-static
 T x@p;
 ... when != x
     when strict
?x = e;
// </smpl>

Signed-off-by: Julia Lawall <redacted>

Acked-by: Linus Walleij <redacted>

Yours,
Linus Walleij

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help