Hello Tejun

On 28/03/2017, Tejun Heo wrote:

Hello,

On Tue, Mar 28, 2017 at 04:57:16PM +0100, Darren Stevens wrote:

quoted

Commit: 5946fdaee4ba(pata_atiixp: Don't use unconnected secondary port
on SB600/SB700) disabled the check for secondary ports on AMD
SB700/710/750

quoted

While these chips have only 1 IDE port, it can be reconfigured on SB7xx
to appear as a secondary channel, especially when 'Legacy IDE emulation'
is enabled, breaking IDE detection on some boards with this chipset.

Fix by removing the check for SB7xx.

Fixes: 5946fdaee4ba(pata_atiixp: Don't use unconnected secondary port
on SB600/SB700)
Signed-off-by: Darren Stevens <redacted>

Hmmm... I can replace the revert with this but can you please explain
why we want this in the commit message?  Also, it'd be nice to cc
Markku and link to his report.

What would you prefer the commit message to say? I was only explaining why the
patch was needed.

I need to fix formatting anyway, as Sergei has pointed out, so either I rework
this or you revert as originally planned and I'll resubmit the original patch
for the SB600 only, whichever works best for you, I'm aware time is an issue
here.

I didn't include Markku as I'm not sure I should be adding people to the
Commit without their express permission.

I'm still quite new at this so sorry for causing all this trouble.

Regards
Darren