Thread (3 messages) 3 messages, 2 authors, 2017-03-06

Re: ata: WARNING in ata_sff_qc_issue

From: Tejun Heo <tj@kernel.org>
Date: 2017-02-28 19:24:57
Also in: lkml

Hello,

On Tue, Feb 28, 2017 at 03:33:48PM +0100, Dmitry Vyukov wrote:
If the WARNING is merely to inform user about invalid protocol, please
issue a single line pr_err without the stack trace (invalid protocol
value may be more interesting).
Yeah, the warning is harmless.  The code was written before
passthrough support and just assumed that nobody higher up in the
stack should be issuing unsupported protocols and warned on such cases
as a precaution.  I'm just gonna drop the WARN.  The error code to sg
command should be enough to indicate the failure.

Thanks.

-- 
tejun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help