Thread (5 messages) 5 messages, 3 authors, 2017-01-08

Re: [V1] ata: sata_mv:- Handle return value of devm_ioremap.

From: Andy Shevchenko <hidden>
Date: 2017-01-08 22:10:09
Also in: lkml

On Sun, Jan 8, 2017 at 8:49 PM, Tejun Heo [off-list ref] wrote:
On Sat, Jan 07, 2017 at 12:52:57AM +0200, Andy Shevchenko wrote:
quoted
On Fri, Jan 6, 2017 at 10:46 PM, Tejun Heo [off-list ref] wrote:
quoted
On Mon, Dec 12, 2016 at 11:13:27PM +0530, Arvind Yadav wrote:
quoted
Here, If devm_ioremap will fail. It will return NULL.
Then hpriv->base = NULL - 0x20000; Kernel can run into
a NULL-pointer dereference. This error check will avoid
NULL pointer dereference.

Signed-off-by: Arvind Yadav <redacted>
Applied to libata/for-4.10-fixes.
Hold on, why not to convert to devm_ioremap_resource() ?
Care to send the patch?
Incremental or substitute?


-- 
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help