Re: [PATCH v6 4/4] SCT Write Same handle ATA_DFLAG_PIO
From: Hannes Reinecke <hare@suse.de>
Date: 2016-08-22 06:31:30
Also in:
lkml
On 08/22/2016 06:23 AM, Shaun Tancheff wrote:
quoted hunk ↗ jump to hunk
Use non DMA write log when ATA_DFLAG_PIO is set. Signed-off-by: Shaun Tancheff <redacted> --- v6: Added check for ATA_DFLAG_PIO and fallback to non DMA write log for SCT Write Same drivers/ata/libata-scsi.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index 37f456e..e50b7a7 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c@@ -3485,6 +3485,8 @@ static unsigned int ata_scsi_write_same_xlat(struct ata_queued_cmd *qc) tf->device = ATA_CMD_STANDBYNOW1; tf->protocol = ATA_PROT_DMA; tf->command = ATA_CMD_WRITE_LOG_DMA_EXT; + if (unlikely(dev->flags & ATA_DFLAG_PIO)) + tf->command = ATA_CMD_WRITE_LOG_EXT; } tf->flags |= ATA_TFLAG_ISADDR | ATA_TFLAG_DEVICE | ATA_TFLAG_LBA48 |
Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)