Re: [PATCH] ata: hpt366: fix incorrect mask when checking at cmd_high_time

From
One Thousand Gnomes <hidden>
Date
2016-07-18 20:15:02
Also in
lkml
Reply to
Colin King, 2016-07-12
On Tue, 12 Jul 2016 12:16:19 +0100
Colin King [off-list ref] wrote:
From: Colin Ian King <redacted>

According to the HPT366 data sheet, PCI config space dword 0x40-0x43
bits 11:8 specify the primary drive cmd_high_time, however,
currently just 3 bits of the 4 are being used because the mask
is 0x700 and not 0x0f00.  Fix the mask, allowing for the 40MHz clock
to be detected.
Is this tested on real hardware ? I learned long ago never to blindly
trust IDE data sheets. It looks right but if anyone actually has a 40MHz
PCI bus box with an HPT366 it would be good to test.

Alan
Thread (5 messages) 5 messages, 4 authors, last reply 2016-07-18
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help