Thread (5 messages) 5 messages, 2 authors, 2014-08-01

Re: [PATCH] ata: libahci: Make host flags unsigned long

From: Tejun Heo <tj@kernel.org>
Date: 2014-08-01 12:52:12
Also in: lkml

On Fri, Aug 01, 2014 at 01:39:41PM +0200, Thierry Reding wrote:
From: Thierry Reding <redacted>

Commit 725c7b570fda (ata: libahci_platform: move port_map parameters
into the AHCI structure) moves flags into the struct ahci_host_priv's
.flags field, which causes compiler warnings on 64-bit builds when that
value is cast to a void * pointer. Rather than adding additional casting
to silence the warning, turn the flags field into a unsigned long.
Unless we're talking about a lot of places where such casting is
necessary, I'd actually prefer to keep the flags uint and use explicit
casting.  How many are we talking about?

Thanks.

-- 
tejun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help