Re: [PATCH 27/29] drivers/ata/sata_rcar.c: simplify use of devm_ioremap_resource
From: Tejun Heo <tj@kernel.org>
Date: 2013-08-14 13:32:55
Also in:
kernel-janitors, lkml
From: Tejun Heo <tj@kernel.org>
Date: 2013-08-14 13:32:55
Also in:
kernel-janitors, lkml
On Wed, Aug 14, 2013 at 11:11:31AM +0200, Julia Lawall wrote:
From: Julia Lawall <redacted> Remove unneeded error handling on the result of a call to platform_get_resource when the value is passed to devm_ioremap_resource. Move the call to platform_get_resource adjacent to the call to devm_ioremap_resource to make the connection between them more clear. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression pdev,res,n,e,e1; expression ret != 0; identifier l; @@ - res = platform_get_resource(pdev, IORESOURCE_MEM, n); ... when != res - if (res == NULL) { ... \(goto l;\|return ret;\) } ... when != res + res = platform_get_resource(pdev, IORESOURCE_MEM, n); e = devm_ioremap_resource(e1, res); // </smpl> Signed-off-by: Julia Lawall <redacted>
Applied to libata/for-3.12. Thanks. -- tejun