Thread (3 messages) 3 messages, 1 author, 2012-12-20

Re: [PATCH] libata-core: disable uninitialized var warning

From: Dirk Behme <hidden>
Date: 2012-12-20 14:14:49

Am 20.12.2012 15:10, schrieb Dirk Behme:
Make GCC happy by disabling the warning

drivers/ata/libata-core.c: In function 'ata_hpa_resize':
drivers/ata/libata-core.c:1394:3: warning: 'native_sectors' may be used uninitialized in this function [-Wmaybe-uninitialized]

Looking on the code, 'native_sectors' is always initialized by calling
ata_read_native_max_address(dev, &native_sectors).

Signed-off-by: Dirk Behme <redacted>
CC: Jeff Garzik <redacted>
Ah, sorry, just saw that there is already a similar discussion from 
today. Seems this didn't make it to Google, yet ;)

Dirk
quoted hunk ↗ jump to hunk
---
  drivers/ata/libata-core.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 9e8b99a..21623cf 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -1324,7 +1324,7 @@ static int ata_hpa_resize(struct ata_device *dev)
  	int print_info = ehc->i.flags & ATA_EHI_PRINTINFO;
  	bool unlock_hpa = ata_ignore_hpa || dev->flags & ATA_DFLAG_UNLOCK_HPA;
  	u64 sectors = ata_id_n_sectors(dev->id);
-	u64 native_sectors;
+	u64 native_sectors = 0 /* GCC */;
  	int rc;

  	/* do we need to do it? */
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help