Re: [PATCH 04/14] libata: implement ata_platform_remove_one()
From: Sergei Shtylyov <hidden>
Date: 2012-11-02 11:08:23
Hello. On 02-11-2012 11:46, Brian Norris wrote:
This relatively simple boiler-plate code is repeated in several platform drivers. We should implement a common version in libata.
Signed-off-by: Brian Norris <computersforpeace@gmail.com> --- drivers/ata/libata-core.c | 23 +++++++++++++++++++++++ include/linux/libata.h | 4 ++++ 2 files changed, 27 insertions(+)
quoted hunk ↗ jump to hunk
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 611050d..820e47f 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c
[...]
quoted hunk ↗ jump to hunk
@@ -6350,6 +6351,26 @@ int ata_pci_device_resume(struct pci_dev *pdev) #endif /* CONFIG_PCI */ +/** + * ata_platform_remove_one- Platform layer callback for device removal + * @pdev: Platform device that was removed + * + * Platform layer indicates to libata via this hook that hot-unplug or + * module unload event has occurred. Detach all ports. Resource + * release is handled via devres. + * + * LOCKING: + * Inherited from platform layer (may sleep). + */ +int ata_platform_remove_one(struct platform_device *pdev) +{ + struct ata_host *host = platform_get_drvdata(pdev); + + ata_host_detach(host);
Indent with tabs, not spaces, as below.
+ + return 0; +} + static int __init ata_parse_force_one(char **cur, struct ata_force_ent *force_ent, const char **reason)
MBR, Sergei