Re: [RFC 3/3] libata: don't perform HW activity in devres
From: Tejun Heo <tj@kernel.org>
Date: 2012-10-25 17:25:48
Also in:
lkml
From: Tejun Heo <tj@kernel.org>
Date: 2012-10-25 17:25:48
Also in:
lkml
On Thu, Oct 25, 2012 at 09:56:01AM -0700, Brian Norris wrote:
devres functions are intended for simplified cleanup of memory and other software resources on device exit, not for hardware shutdown sequences. In addition, inducing hardware activity at device removal hamstrings some drivers (particularly ahci_platform) so that they cannot totally power off their hardware before removal, as devres cleanup occurs after the driver's exit() sequence. More concretely, I experience the following bus error when using rmmod to remove (and power off) the SATA block on my SoC:
Shouldn't poweroff happen from ->port/host_stop()? Thanks. -- tejun