Re: Deferred disk spinup during system resume

Hello, Brian.

On Fri, Aug 17, 2012 at 07:12:30PM -0700, Brian Norris wrote:

I understand that your original patch was given the "not tested"
disclaimer, but I wanted to know if you had any immediate advice on
why this failed so miserably for me, before I go trying to dig in to
this issue more deeply. For instance, maybe there's been enough code
change between 2.6.37 and 3.3 (or current upstream - 3.6-rc2) that
would require a change in approach.

Yeah, I'm not particularly fond of how resume is implemented.  It can
and should be more asynchronous, I think. :( Unfortunately, I'm a bit
too preoccupied at the moment.  A quick & dirty hack would be simply
skipping ATA_CMD_VERIFY so that the drive spins up on the actual next
command.  If that's acceptable, just add "goto skip;" right after "if
(cdb[4] & 0x1)" test in ata_scsi_start_stop_xlat().

Thanks.

-- 
tejun