Re: [RFC][PATCH] libata: enable SATA disk fua detection on default
From: Zheng Liu <hidden>
Date: 2012-07-03 08:56:29
Also in:
linux-scsi, lkml
Hi Jeff, Sorry for bothering you. Could you please review this patch, or give me some feedbacks. If this patch can be applied, I can rebase it to the lastest version of mainline kernel. Thank you. Regards, Zheng On Tue, May 08, 2012 at 11:24:03AM +0800, Zheng Liu wrote:
quoted hunk ↗ jump to hunk
From: Zheng Liu <redacted> Currently, SATA disk fua detection is disabled on default because most of devices don't support this feature at that time. With the development of technology, more and more SATA disks support this feature. So now we can enable this detection on default. Although fua detection is defined as a kernel module parameter, it is too hard to set its value because it must be loaded and set before system starts up. That needs to modify initrd file. So it is inconvenient for administrator who needs to manage a huge number of servers. CC: Jeff Garzik <redacted> Signed-off-by: Zheng Liu <redacted> --- drivers/ata/libata-core.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 23763a1..3627251 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c@@ -133,9 +133,9 @@ int atapi_passthru16 = 1; module_param(atapi_passthru16, int, 0444); MODULE_PARM_DESC(atapi_passthru16, "Enable ATA_16 passthru for ATAPI devices (0=off, 1=on [default])"); -int libata_fua = 0; +int libata_fua = 1; module_param_named(fua, libata_fua, int, 0444); -MODULE_PARM_DESC(fua, "FUA support (0=off [default], 1=on)"); +MODULE_PARM_DESC(fua, "FUA support (0=off, 1=on [default])"); static int ata_ignore_hpa; module_param_named(ignore_hpa, ata_ignore_hpa, int, 0644);-- 1.7.4.1