Thread (9 messages) flat view 9 messages, 4 authors, 2012-06-12

Re: [PATCH 1/7] drivers/ide/ide-cs.c: adjust suspicious bit operation

From: David Miller <davem@davemloft.net>
Date: 2012-06-07 21:46:19
Also in: kernel-janitors, lkml

From: Julia Lawall <redacted>
Date: Wed,  6 Jun 2012 23:41:35 +0200
-	if (!(pdev->resource[0]->flags & IO_DATA_PATH_WIDTH_8)) {
+	if ((p1dev->resource[0]->flags & IO_DATA_PATH_WIDTH)
I'm really surprised someone as thorough as yourself did not
compile test this.

This is just more proof that it's absolutely pointless to make any
changes at all to the old IDE layer.  Nobody really cares, and the
risk %99.999 of the time is purely to introduce regressions rather
than make forward progress.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help