Thread (2 messages) 2 messages, 2 authors, 2012-06-02
STALE5161d

[PATCH] ide: icside.c: fix printk format string compile warning

From: Christian Dietrich <hidden>
Date: 2012-05-31 10:32:12
Also in: lkml
Subsystem: the rest · Maintainer: Linus Torvalds

Possibly related (same subject, not in this thread)

Peak datarate is never bigger than an integer, and can therefore, as
suggested in the printk format string, casted to an integer.
---
 drivers/ide/icside.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/ide/icside.c b/drivers/ide/icside.c
index 83e5100..755ef6b 100644
--- a/drivers/ide/icside.c
+++ b/drivers/ide/icside.c
@@ -271,9 +271,9 @@ static void icside_set_dma_mode(ide_hwif_t *hwif, ide_drive_t *drive)
 
 	ide_set_drivedata(drive, (void *)cycle_time);
 
-	printk("%s: %s selected (peak %dMB/s)\n", drive->name,
-		ide_xfer_verbose(xfer_mode),
-		2000 / (unsigned long)ide_get_drivedata(drive));
+	printk(KERN_INFO "%s: %s selected (peak %dMB/s)\n", drive->name,
+	       ide_xfer_verbose(xfer_mode),
+	       (int) (2000 / (unsigned long)ide_get_drivedata(drive)));
 }
 
 static const struct ide_port_ops icside_v6_port_ops = {
-- 
1.7.5.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help