On 05/02/2012 03:46 PM, Tejun Heo wrote:

On Wed, May 02, 2012 at 03:43:05PM -0400, Mark Lord wrote:

quoted

quoted

quoted

+static inline int ata_eh_worth_retry(struct ata_queued_cmd *qc)

Return bool?&&  maybe split the patch into two - the first separating
out the logic into a function, the latter changing emedia handling?

I think the two-liner from v2 is better.

Heh, I don't know.  It probably doesn't matter all that much either
way.  Let's let Jeff decide. ;)

Queued v3.  If anyone is motivated to make additional changes, base them 
on top of v3...