Thread (26 messages) 26 messages, 7 authors, 2012-02-16

Re: Regression 3.2 -> 3.3-rc1 10 sec hang at boot and resume, COMRESET failed

From: Lin Ming <hidden>
Date: 2012-02-06 01:37:02
Also in: lkml
Subsystem: libata subsystem (serial and parallel ata drivers), the rest · Maintainers: Damien Le Moal, Niklas Cassel, Linus Torvalds

Possibly related (same subject, not in this thread)

On Mon, 2012-02-06 at 09:46 +0900, Norbert Preining wrote:
Hi Lin,


sorry for the delay, weekend I was off ...

On Fr, 03 Feb 2012, Lin Ming wrote:
quoted
quoted
Confirmed. Reverted 7faa33da9b7 on top of 6c073a7ee250 made
the boot delay go away. dmesg from this boot attached.
Dig into the code, but I can't find where the problem is.

Anyway, does below DEBUG patch help?
Let's always stop the engine during hard reset.
If you meant: 
  "Try that patch on top of HEAD *without* reverting 7faa33da9b7?"
then I can report that it does NOT help. With *only* this patch I still
get 10sec delay, and otherwise nothing changes.
Does below help?
diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index a72bfd0..33f7333 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -746,6 +746,9 @@ static void ahci_start_port(struct ata_port *ap)
 	/* enable FIS reception */
 	ahci_start_fis_rx(ap);
 
+	/* enable DMA */
+	ahci_start_engine(ap);
+
 	/* turn on LEDs */
 	if (ap->flags & ATA_FLAG_EM) {
 		ata_for_each_link(link, ap, EDGE) {
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help