Re: [PATCH v2 26/28] libsas: check for 'gone' expanders in smp_execute_task()
From: Dan Williams <hidden>
Date: 2012-01-09 19:04:46
Also in:
linux-scsi
On Thu, Dec 22, 2011 at 7:00 PM, Dan Williams [off-list ref] wrote:
quoted hunk ↗ jump to hunk
No sense in issuing or retrying commands to an expander that has been removed. Signed-off-by: Dan Williams <redacted> --- drivers/scsi/libsas/sas_expander.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c index d9c2769..e2efc6c 100644 --- a/drivers/scsi/libsas/sas_expander.c +++ b/drivers/scsi/libsas/sas_expander.c@@ -74,6 +74,9 @@ static int smp_execute_task(struct domain_device *dev, void *req, int req_size,mutex_lock(&dev->ex_dev.cmd_mutex); for (retry = 0; retry < 3; retry++) { + if (dev->gone) + return -ECOMM; +
Test results are just now tripping up on this obvious deadlock. Will resend. -- Dan -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html