RE: [PATCH][SDK v1.2] sata: I/O load balancing
From: Liu Qiang-B32616 <hidden>
Date: 2012-01-13 09:57:41
Also in:
linuxppc-dev, lkml
________________________________________
From: linux-ide-owner@vger.kernel.org [linux-ide-owner@vger.kernel.org] on behalf of Li Yang [leoli@freescale.com] Sent: Friday, January 13, 2012 3:36 AM To: Liu Qiang-B32616 Cc: jgarzik@pobox.com; linux-ide@vger.kernel.org; linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Liu Qiang-B32616 Subject: Re: [PATCH][SDK v1.2] sata: I/O load balancing
On Fri, Jan 13, 2012 at 4:25 PM, Qiang Liu [off-list ref] wrote:quoted
From: Qiang Liu <redacted> Reduce interrupt singnals through reset Interrupt Coalescing Control Reg. Increase the threshold value of interrupt and timer will reduce the number of complete interrupt sharply. Improve the system performance effectively.
There is always a trade off of throughput and latency by using interrupt coalescing. It's not reasonable to assume that the throughput is the only factor to be considered and set the coalescing threshold and timeout to the max value by default. Have you carried out other benchmark like copying many small files?
No, I didn't test small file. I think this won't affect system load. I can have a test and describe the result in next patch.
It will be safer to make the coalescing runtime configurable like the sata_mv driver, IMO.
Ok, I will do it like this in next patch. - Leo -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html