Thread (41 messages) 41 messages, 5 authors, 2012-01-06

Re: [PATCH block:for-3.3/core] cfq: merged request shouldn't jump to a different cfqq

From: Tejun Heo <tj@kernel.org>
Date: 2012-01-06 03:04:14
Also in: linux-next, linux-scsi, lkml

Hello,

On Fri, Jan 06, 2012 at 11:14:15AM +0800, Shaohua Li wrote:
quoted
So, yeah, the right fix would be using elv_former/latter_request()
instead.  Maybe we should strip out rqhash altogether and change
elevator handle everything?  I don't know.  I'll prepare a different
fix patch soon.
So not allow merge from two cfq queues strictly? This will impact
performance. I don't know how important the strict isolation is. we even
allow two cfq queues merge to improve performance.
That's how cfq has behaved before this recent plug merge breakage and
IIRC why the cooperating queue thing is there.  If you want to change
the behavior, that should be an explicit separate patch.

Thanks.

-- 
tejun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help