Thread (63 messages) 63 messages, 17 authors, 2011-12-07

Re: [PATCH] ata: Don't use NO_IRQ in pata_of_platform driver

From: Alan Cox <hidden>
Date: 2011-12-05 18:44:25
Also in: linux-arm-kernel, linux-devicetree, linux-next, lkml

But as you illustrated, there is a large number of drivers that already 
assume no IRQ is < 0, even if they don't use any IRQ #0 themselves.  
That is a much bigger problem to fix.
And a much larger number assuming the reverse is true which are hiding
potential bugs on ARM.

Looking at the serial stuff the best checks appear to be looking at
"irq", "-1" and NO_IRQ.

For migration stuff that's doing broken things like

	if (irq < 0)

can be changed to

	if (irq <= 0)

and that can be done before NO_IRQ itself is nailed on ARM and PA-RISC.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help