Hello.

Jeff Garzik wrote:

quoted

On Sun, 2011-04-24 at 14:28 -0500, James Bottomley wrote:

quoted

currently libata-sff is completely ignoring the enabled/disabled status
of the interfaces.  This is a real problem on parisc because if you
touch a non responding memory area (i.e. a disabled interface) you crash
the box.

quoted

quoted

Fix by checking the CNTRL bits to see if the port is enabled before
trying to poke it.

quoted

Ping on this.

quoted

Since 1/2 is an essential fix to prevent a boot panic on parisc, I can
just take them through the parisc tree.

It's in libata-dev.git#upstream and #NEXT (linux-next) at present.

    I'm wondering about the other drivers that check the channel enable bits in 
their prereset() methods. James has shown that such code would still crash on 
such platforms as PARISC (I suspect many more platfroms which don't silently 
ignore the target aborts in the PCI space like x86 does). I think all such 
drivers should be converted to the early port disable detection scheme used in 
the pata_cmd64x driver (an some others)...

    Jeff

WBR, Sergei