Re: [PATCH 05/35] drivers/ata changes for SMBIOS and System Firmware
From: Jeff Garzik <hidden>
Date: 2011-06-23 21:33:09
Also in:
lkml
On 06/23/2011 01:22 PM, Prarit Bhargava wrote:
drivers/ata changes for SMBIOS and System Firmware As part of the new SMBIOS and System Firmware code: - Replace old dmi* structures and functions with new sysfw* and smbios* structures and functions in individual drivers - cleanup sysfw_id lookup tables - cleanup of includes for dmi.h and mod_devicetable.h which were included in some files that did not need them Signed-off-by: Prarit Bhargava<redacted> --- drivers/ata/acard-ahci.c | 1 - drivers/ata/ahci.c | 177 +++++++++++++++++++++++---------------------- drivers/ata/ata_piix.c | 156 +++++++++++++++++++++++----------------- drivers/ata/pata_ali.c | 18 +++--- drivers/ata/pata_cs5530.c | 12 ++-- drivers/ata/pata_rdc.c | 1 - drivers/ata/pata_sch.c | 1 - drivers/ata/pata_via.c | 14 ++-- drivers/ata/sata_sil.c | 19 +++--- 9 files changed, 210 insertions(+), 189 deletions(-)
#ifdef CONFIG_PM
+bool sysfw_match(int field, const char *str)
+{
+ const char *info = sysfw_lookup(field);
+
+ if (info == NULL || str == NULL)
+ return info == str;
+
+ return !strcmp(info, str);
+}It is surprising that nobody else needed this. I would rather that this sort of thing go into the generic code, where it lived prior to this change. Either way, though, Acked-by: Jeff Garzik <redacted> I presume you'll merge this at the same time as the rest of the rename changes.