Thread (2 messages) 2 messages, 2 authors, 2011-05-31

Re: [PATCH 2/2] ide-cd: Fix another signedness warning

From: David Miller <davem@davemloft.net>
Date: 2011-05-31 22:25:59
Also in: lkml

From: Connor Hansen <redacted>
Date: Mon, 30 May 2011 00:26:58 -0700
One of the legit warnings 'make W=3 drivers/ide/ide-cd.o generates is

drivers/ide/ide-cd.c: In function ide_cd_queue_pc:
drivers/ide/ide-cd.c:451:3: warning: conversion to unsigned int from
      int may change the sign of the result

timeout is passed as an int, but is declared as an unsigned int in
struct request in include/linux/blkdev.h

Signed-off-by: Connor Hansen <redacted>
This is beyond academic and may in fact introduce strange things.

All except one call site passes "0" for the timeout.

And that one call site passes packet_command->timeout from userspace
which is an 'int'.

I'm not applying this.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help