Re: [PATCH] ata: pata_at91.c bugfix for initial_timing initialisation
From: Eric Dumazet <hidden>
Date: 2011-03-28 12:09:36
Also in:
lkml
From: Eric Dumazet <hidden>
Date: 2011-03-28 12:09:36
Also in:
lkml
Le lundi 28 mars 2011 à 15:59 +0400, Igor Plyatov a écrit :
The "struct ata_timing" must contain 10 members, but ".dmack_hold" member was forgotten for "initial_timing" initialisation. This patch fixes such a problem. Signed-off-by: Igor Plyatov <redacted> --- drivers/ata/pata_at91.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)diff --git a/drivers/ata/pata_at91.c b/drivers/ata/pata_at91.c index 0da0dcc..d1aaeb5 100644 --- a/drivers/ata/pata_at91.c +++ b/drivers/ata/pata_at91.c@@ -49,8 +49,9 @@ struct at91_ide_info { void __iomem *alt_addr; }; -static const struct ata_timing initial_timing = - {XFER_PIO_0, 70, 290, 240, 600, 165, 150, 600, 0}; +static const struct ata_timing initial_timing = { + XFER_PIO_0, 70, 290, 240, 600, 165, 150, 600, 0
Oh well. XFER_PIO_0, 70, 290, 240, 600, 165, 150, 0, 600, 0 Or even better, use C99 initializer ?