Re: [PATCH 04/16] ide: Convert to bdops->check_events()
From: David Miller <davem@davemloft.net>
Date: 2011-03-09 22:16:53
Also in:
lkml
Possibly related (same subject, not in this thread)
- 2010-12-28 · Re: [PATCH 04/16] ide: convert to bdops->check_events() · David Miller <davem@davemloft.net>
- 2010-12-28 · [PATCH 04/16] ide: convert to bdops->check_events() · Tejun Heo <tj@kernel.org>
From: Tejun Heo <tj@kernel.org> Date: Wed, 9 Mar 2011 10:13:24 +0100
Convert ->media_changed() to the new ->check_events() method. The conversion is mostly mechanical. The only notable change is that cdrom now doesn't generate any event if @slot_nr isn't CDSL_CURRENT. It used to return -EINVAL which would be treated as media changed. As media changer isn't supported anyway, this doesn't make any difference. This makes ide emit the standard disk events and allows kernel event polling. Currently, only MEDIA_CHANGE event is implemented. Adding support for EJECT_REQUEST shouldn't be difficult; however, given that ide driver is already deprecated, it probably is best to leave it alone. Signed-off-by: Tejun Heo <tj@kernel.org> Acked-by: Jens Axboe <axboe@kernel.dk>
Acked-by: David S. Miller <davem@davemloft.net>