Re: [PATCH] libata: Include WWN ID in inquiry VPD emulation

On 03/07/2011 03:53 AM, Hannes Reinecke wrote:

On 03/07/2011 09:27 AM, Jeff Garzik wrote:

quoted

On 03/07/2011 02:57 AM, Hannes Reinecke wrote:

quoted

On 03/04/2011 06:22 PM, Jeff Garzik wrote:

quoted

And if you're highly motivated, a separate patch to update
include/linux/ata.h to return bool for obvious ata_id_has_xxx functions
would be nice too.

quoted

Like this?

quoted

-static inline int ata_id_has_fua(const u16 *id)
+static inline bool ata_id_has_fua(const u16 *id)
  {
      if ((id[ATA_ID_CFSSE]&  0xC000) != 0x4000)
          return 0;
      return id[ATA_ID_CFSSE]&  (1<<  6);
  }

Not _quite_ that easy...  one must also s/0/false/ and s/1/true/ where
the return value is explicit, rather than the result of an expression.

Ok, there you go.

looks good, except for the part where it doesn't build ;)

Make that micro-fix, and resend as a normal patch, and I'll apply 
straightaway.