Re: [PATCH 1/1] PCI: tune up ICH4 quirk for broken BIOSes
From: Jiri Slaby <hidden>
Date: 2011-02-08 09:55:17
Also in:
lkml
On 01/14/2011 05:10 PM, Bjorn Helgaas wrote:
On Friday, January 14, 2011 03:31:16 am Jiri Slaby wrote:quoted
On 01/14/2011 01:15 AM, Linus Torvalds wrote:quoted
On Thu, Jan 13, 2011 at 3:19 PM, Bjorn Helgaas [off-list ref] wrote:quoted
I think we're back to the question of why we have the ICH4 quirk in the first place, and I don't know the answer to that.Iirc, there were several laptops that didn't have the ACPI region mentioned in any of the regular places, and we'd allocate the PCMCIA IO region on top of them. The machine would boot, but if anybody ever inserted a PCCard into the machine, the first access to the IO region would generally just halt it (because it was trying to read the PCCard, but the APCI region decodes first, and then the read from that usually put the CPU in a sleep state that it would never wake up from for obvious reasons). So we do want the ICH4 quirk.Yes, this is an "official" way how ICH4 (and later) advertises the region.The quirk is a bug workaround, *not* the "official, planned" way to deal with these regions. The official way is to use ACPI, because that's a generic way that doesn't require changes for new versions of ICH.
Ok, I understand that. For non-ACPI setups this is probably the only place to look at. Anyway, has anybody had a chance to look at the patches? Any comments, nacks/acks? https://lkml.org/lkml/2011/1/14/115 https://lkml.org/lkml/2011/1/14/113 https://lkml.org/lkml/2011/1/14/114 thanks, -- js