Thread (62 messages) 62 messages, 7 authors, 2010-09-07

Re: [PATCH] SATA / AHCI: Do not play with the link PM during suspend to RAM

From: Rafael J. Wysocki <hidden>
Date: 2010-08-24 20:41:28
Also in: linux-pm, lkml

On Tuesday, August 24, 2010, Tejun Heo wrote:
On 08/23/2010 08:58 PM, Rafael J. Wysocki wrote:
quoted
On Monday, August 23, 2010, Tejun Heo wrote:
quoted
Hello, sorry about the delay.

On 08/19/2010 06:23 PM, Stephan Diestelhorst wrote:
quoted
It says "max_performance", I have not touched anyhting. So it has been
like that all the time. Would this explain why your patch did not show
the debug printout?
Hmm... okay.  Yeah, if you haven't been using IPM at all, there won't
be any debug messages but at the same time the posted patch should
have had the same effect as Rafael's patch as IPM path isn't traveled
at all.  Can you please check the followings?

* You're actually running the correct patched kernel and modules.  It
  probably is a good idea to add a printk message.  ie. Apply the
  patch and add a printk() in ata_host_request_pm() in libata-core.c
  and make sure the debug messages appears.

* Rafael's patch actually fixes the problem.  If you haven't been
  using IPM at all, Rafael's patch and mine should behave exactly the
  same (ie. no IPM operation at all during suspend/resume).  It could
  be that you're seeing a different issue.

Rafael, can you please test my patch and see how your case behaves?
This one: http://lkml.org/lkml/2010/8/5/328 ?
Yeap, that one.  I can prep a test git branch if necessary.
No need to, but it's going to take a few days to verify on my box.

Thanks,
Rafael
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help