Thread (6 messages) 6 messages, 2 authors, 2009-11-23

Re: drivers/ide/au1xxx-ide.c: use resource_size()

From: David Miller <davem@davemloft.net>
Date: 2009-11-23 18:28:00
Also in: lkml

From: "H Hartley Sweeten" <redacted>
Date: Mon, 23 Nov 2009 13:15:32 -0500
Use resource_size() for {request/release}_mem_region and ioremap.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Applied to ide-next-2.6, thanks.
 
-	ahwif->regbase = (u32)ioremap(res->start, res->end - res->start + 1);
+	ahwif->regbase = (u32)ioremap(res->start, resource_size(res));
 	if (ahwif->regbase == 0) {
 		ret = -ENOMEM;
 		goto out;
That needs some fixing.  ioremap()'s return value is an
"__iomem" pointer, not an integer.  ->regbase's type should be
changed to something like "void __iomem *" etc.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help