Re: [patch][repost] ide-tape build fix
From: Borislav Petkov <hidden>
Date: 2008-10-08 06:34:18
Also in:
lkml
Hi, On Tue, Oct 07, 2008 at 08:26:15PM +0200, Mark de Wever wrote:
I never got a reaction on this patch, but please apply it. In order to compile the kernel with IDETAPE_DEBUG_LOG enabled I had to apply the following build fix.
Bugger, I should be getting at least warnings when compiling this but I don't. This is because I don't have CONFIG_LBD enabled. However, the %ld and %d format specifiers are also not entirely correct but gcc doesn't warn about them - I guess it checks only size but not signedness...
quoted hunk ↗ jump to hunk
Signed-off-by: Mark de Wever <redacted>diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 3833189..7258eca 100644 --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide-tape.c@@ -978,9 +978,10 @@ static ide_startstop_t idetape_do_request(ide_drive_t *drive, struct request *postponed_rq = tape->postponed_rq; u8 stat; - debug_log(DBG_SENSE, "sector: %ld, nr_sectors: %ld," + debug_log(DBG_SENSE, "sector: %llu, nr_sectors: %ld,"
the other format specifiers should be rq->nr_sectors: %lu, rq->current_nr_sectors: %u.
" current_nr_sectors: %d\n",
- rq->sector, rq->nr_sectors, rq->current_nr_sectors);
+ (unsigned long long)rq->sector, rq->nr_sectors,
+ rq->current_nr_sectors);
if (!blk_special_request(rq)) {
/* We do not support buffer cache originated requests. */
Would you like to redo your patch and add a proper comment ontop?
Thanks.
--
Regards/Gruss,
Boris.