[PATCH 01/10] ide: fix pre-EIDE SWDMA support on big-endian
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Date: 2008-07-22 21:15:16
Also in:
lkml
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Date: 2008-07-22 21:15:16
Also in:
lkml
id->tDMA is of 'unsigned char' type so endianness is already correct and calling le16_to_cpu() is wrong. Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/ide-dma.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) Index: b/drivers/ide/ide-dma.c ===================================================================
--- a/drivers/ide/ide-dma.c
+++ b/drivers/ide/ide-dma.c@@ -649,11 +649,7 @@ static unsigned int ide_get_mode_mask(id if (id->field_valid & 2) { mask = id->dma_1word & hwif->swdma_mask; } else if (id->tDMA) { - /* - * ide_fix_driveid() doesn't convert ->tDMA to the - * CPU endianness so we need to do it here - */ - u8 mode = le16_to_cpu(id->tDMA); + u8 mode = id->tDMA; /* * if the mode is valid convert it to the mask