Thread (32 messages) 32 messages, 7 authors, 2008-06-09

Re: [PATCH] libata: Handle bay devices in dock stations

From: Holger Macht <hidden>
Date: 2008-05-29 14:11:34
Also in: linux-acpi, lkml

On Thu 29. May - 15:02:13, Matthew Garrett wrote:
On Thu, May 29, 2008 at 10:44:29PM +0900, Tejun Heo wrote:
quoted
Does this fix the problem?
No, I'm seeing an identical hang. Mainline works fine.
Maybe you could also try this on top of Tejun's patch?
--- linux-2.6/drivers/ata/libata-acpi.c.orig	2008-05-29 16:13:00.000000000 +0200
+++ linux-2.6/drivers/ata/libata-acpi.c	2008-05-29 16:13:04.000000000 +0200
@@ -237,10 +237,8 @@
 
 	spin_unlock_irqrestore(ap->lock, flags);
 
-	if (wait) {
+	if (wait)
 		ata_port_wait_eh(ap);
-		ata_acpi_eject_device(handle);
-	}
 
 	if (kobj && !is_dock_event) {
 		sprintf(event_string, "BAY_EVENT=%d", event);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help