Re: [PATCH] ide-core: remove conditional compiling with MODULE in ide-core.c
From: Bodo Eggert <hidden>
Date: 2008-02-02 18:58:33
Also in:
lkml
Denis Cheng [off-list ref] wrote:
use module_init/module_exit to replace the original cond-compiling, these
macros were well designed to deal module/built-in compiling.
the original __setup with null string was invalid and not executed,
__setup("", ide_setup);
however, with the current module_param mechanics, module parameters also can
be input on the kernel command line, with this style:
ide-core.options="ide=nodma hdd=cdrom idebus=..."
so Documentation/kernel-parameters.txt also updated.quoted hunk
--- a/Documentation/kernel-parameters.txt
quoted hunk
- ide= [HW] (E)IDE subsystem - Format: ide=nodma or ide=doubler or ide=reverse - See Documentation/ide.txt. - - ide?= [HW] (E)IDE subsystem - Format: ide?=noprobe or chipset specific parameters. - See Documentation/ide.txt. - - idebus= [HW] (E)IDE subsystem - VLB/PCI bus speed + ide-core.options= [HW] (E)IDE subsystem + Format: ide-core.options="ide=nodma hdd=cdrom idebus=..."
IMO you should use separate options for things like nodma while you're at it. ¢¢