Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays
From: Rusty Russell <hidden>
Date: 2008-01-07 05:28:35
Also in:
linux-scsi, lkml
From: Rusty Russell <hidden>
Date: 2008-01-07 05:28:35
Also in:
linux-scsi, lkml
On Monday 07 January 2008 16:01:40 Tejun Heo wrote:
quoted
But we hit the same problems: 1) sg_chain loses information. The clever chain packaging makes reading easy, but manipulation is severely limited. You can append to your own chains by padding, but not someone elses. This works for SCSI, but what about the rest of us? And don't even think of joining mapped chains: it will almost work.You can append by allocating one more element on the chain to be appended and moving the last element of the first chain to it while using the last element for chaining.
Hi Tejun, Nice try! Even ignoring the ugliness of undoing such an operation if the caller doesn't expect you to mangle their chains, consider a one-element sg array. :( Cheers, Rusty.