Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR
From: Jeff Garzik <hidden>
Date: 2007-09-26 04:03:32
Also in:
lkml
Peer Chen wrote:
quoted hunk ↗ jump to hunk
According to the description of section 5.2.2.1 and 10.1.2 of AHCI specification rev1_1/rev1_2, GHC.HR shall only be set to ¡®1¡¯ by software when GHC.AE is set to ¡®1¡¯. Signed-off-by: Peer Chen <redacted> ------ linux-2.6.23-rc7/drivers/ata/ahci.c.orig 2007-09-20 11:01:55.000000000 -0400 +++ linux-2.6.23-rc7/drivers/ata/ahci.c 2007-09-20 11:07:31.000000000 -0400@@ -834,6 +834,10 @@ static int ahci_reset_controller(struct void __iomem *mmio = host->iomap[AHCI_PCI_BAR]; u32 tmp; + /* turn on AHCI mode before controller reset*/ + writel(HOST_AHCI_EN, mmio + HOST_CTL); + (void) readl(mmio + HOST_CTL); /* flush */
applied the attached patch, inspired by yours.