Thread (2 messages) 2 messages, 2 authors, 2007-09-03

Re: [PATCH resubmit] /drivers/ata ioremap returncode check

From: Tejun Heo <hidden>
Date: 2007-09-03 08:30:25
Also in: kernel-janitors, lkml

Scott Thompson wrote:
Patchset against 2.6.23-rc3.  corrects missing ioremap return 
checks, resending after fixing for documentation making changes suggested...

As for suggestions, I did fix the {} that weren't needed.  I did not add in a
"printk" err or warn statement as the rest of the module does not contain these
messages.  When auditing (as I am for ioremap checking here) I am attempting
to keep changes "in the style of their surroundings".  Otherwise it's massive
scope screep on these patches.
 
Signed-off-by: Scott Thompson <postfail <at> hushmail.com>
Acked-by: Tejun Heo <redacted>

It would be better to start the subject line with pata_ixp4xx_cf: but
maybe Jeff can fix it up while applying.

Thanks.

-- 
tejun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help