Thread (10 messages) 10 messages, 7 authors, 2007-09-11

Re: [lm-sensors] [PATCH] drivers/firmware: const-ify DMI API and internals

From: Jean Delvare <hidden>
Date: 2007-09-02 17:16:45
Also in: lkml

On Sat, 1 Sep 2007 10:27:19 -0400, Jeff Garzik wrote:
commit 457b6eb3bf3341d2e143518a0bb99ffbb8d754c4
Author: Jeff Garzik [off-list ref]
Date:   Sat Sep 1 10:16:45 2007 -0400

    drivers/firmware: const-ify DMI API and internals
    
    Three main sets of changes:
    
    1) dmi_get_system_info() return value should have been marked const,
       since callers should not be changing that data.
    
    2) const-ify DMI internals, since DMI firmware tables should,
       whenever possible, be marked const to ensure we never ever write to
       that data area.
    
    3) const-ify DMI API, to enable marking tables const where possible
       in low-level drivers.
    
    And if we're really lucky, this might enable some additional
    optimizations on the part of the compiler.
    
    The bulk of the changes are #2 and #3, which are interrelated.  #1 could
    have been a separate patch, but it was so small compared to the others,
    it was easier to roll it into this changeset.
    
    Signed-off-by: Jeff Garzik [off-list ref]
Looks alright to me, thanks Jeff.

-- 
Jean Delvare
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help