Thread (6 messages) 6 messages, 2 authors, 2007-05-23

Re: [PATCH] ata: pata_platform: Disable prereset logic.

From: Paul Mundt <hidden>
Date: 2007-05-23 08:31:27
Also in: lkml

On Wed, May 23, 2007 at 10:07:08AM +0200, Tejun Heo wrote:
Paul Mundt wrote:
quoted
On a number of boards the current prereset logic seems to misbehave:

scsi0 : pata_platform
ata1: PATA max PIO0 cmd 0xb06001f0 ctl 0xb06003f6 bmdma 0x00000000 irq 0
ata1: device not ready (errno=-19), forcing hardreset
ata1: BUG: prereset() requested invalid reset type

This triggers when there is no card inserted in the slot.

Simply disabling the prereset gets rid of this, and doesn't seem to cause
any problems for either PCMCIA or CF cards when they're actually present.
NACK.  The BUG printking needs fixing but you can't just kill
prereset().  Did it work properly on 2.6.21.1?  Can you modify
ata_wait_ready() such that it prints out the status value while waiting?
ata_wait_ready() works fine, it reports 0xff immediately (and this is
what I would expect when there is no card inserted).

The board that exhibits this behaviour wasn't supported in the older
kernels, I can backport and test if it will be useful, though.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help