On Tue, Aug 08 2006, Jiri Slaby wrote:

Jens Axboe wrote:

quoted

On Tue, Aug 08 2006, Rafael J. Wysocki wrote:

quoted

On Tuesday 08 August 2006 13:19, Jens Axboe wrote:

quoted

On Tue, Aug 08 2006, Rafael J. Wysocki wrote:

quoted

On Tuesday 08 August 2006 13:07, Jens Axboe wrote:

quoted

On Tue, Aug 08 2006, Jens Axboe wrote:

quoted

quoted

Indeed, that looks broken now. That must be what is screwing it up. 
With

the former patch applied, did cdrom detection still look funny to you?

Hm, I'm not sure what you mean ...

-hdc: ATAPI 63X DVD-ROM DVD-R CD-R/RW drive, 2048kB Cache, UDMA(33)
+hdc: ATAPI CD-ROM drive, 0kB Cache, UDMA(33)

Ah, that.

quoted

But perhaps that wasn't you?

No, that wasn't me. :-)

It was me and it's OK.

quoted

quoted

quoted

quoted

quoted

quoted

I'll concoct a fix for that breakage.

Something like this.

Looks good, I'll give it a try.

Thanks!

It fixes this particular issue for me, but your first patch (appended)
is also needed to prevent the box from hanging later during the resume
(when it tries to save the image).

Yes certainly, that's a separate bug, sorry if I didn't make that clear.
Both fixes are in the block repo now, so next -mm should work fine
again.

And even this is OK.

Good.

I think that -mm also added barriers on by default for ext3, so I don't
think it's anything to worry about.

-- 
Jens Axboe