Re: [PATCH 1/2] libata: implement to get tf's from _GTF and execute them
From: Sergei Shtylyov <hidden>
Date: 2006-08-09 12:28:14
From: Sergei Shtylyov <hidden>
Date: 2006-08-09 12:28:14
Hello. Jeff Garzik wrote:
quoted
quoted
diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c index 386e5f2..cd4cf97 100644 --- a/drivers/scsi/libata-core.c +++ b/drivers/scsi/libata-core.c@@ -91,6 +91,10 @@ static int ata_probe_timeout = ATA_TMOUT module_param(ata_probe_timeout, int, 0444); MODULE_PARM_DESC(ata_probe_timeout, "Set ATA probing timeout(seconds)");
quoted
quoted
+int noacpi = 0;
quoted
Drop the "= 0". It will be init. to 0 anyway. (Yes, I know my patch had that. :)
Not necessarily true, since it is not static...
All uninitialized explicitly non-auto variables go into .bss section and
get initialized to 0 and 'static' has nothing to do with it, IIRC...
WBR, Sergei