Thread (33 messages) 33 messages, 5 authors, 2006-02-09

[PATCHSET] libata: various fixes related to EH, take #2

From: Tejun Heo <hidden>
Date: 2006-01-23 04:09:41

Hello, again.

Changes from the last posting.

* 1-3 are unchanged (my previous comment about missing ata_qc_free was
  false alarm)

* the detailed AC_ERR_* patch is fixed and splitted into two - AHCI
  qc->err_mask fix and detailed AC_ERR_* change.

* added CC to James and linux-scsi for SCSI change

* the not-yet-agreed-upon ignore-normal-qc-completion-during-EH patch
  is dropped.  I'll give it more thoughts and visit it again soon.

* eh-pio-sync patch is splitted into two as suggested and HSM resetting
  is moved into ->eng_timeout.

The following issues remain in this take.

* In detailed AC_ERR_* patch, I haven't added AC_ERR_ATA_BUS on timeout
  cases.  I still think leaving it as it is is better (heh, two
  consecutive is'es).  If you think AC_ERR_ATA_BUS must be set there,
  I'm okay with that too.  I'll do another take.

* patch #9 which fixes race between timeout and completion isn't exactly
  acked yet.

Thanks.

--
tejun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help