Re: [PATCH 2/5] sil24: add sil24_restart_controller

On Wed, Nov 16, 2005 at 10:26:02AM -0800, Edward Falk wrote:

quoted

+static int __sil24_restart_controller(void __iomem *port)

Hi; I'm curious:  why the leading underscores in the function name?

	-ed falk

Hi, Edward.

It's the same as sil24_reset_controller.  __sil24_restart_controller
takes 'void __iomem *port' and sil24_restart_controller takes 'struct
ata_port *ap)' and prints error message when it fails.  The
underscored versions are needed as they are called from sil24_init_one
where we don't have ap yet.  __sil24_restart_controller isn't directly
 called from sil24_init_one but __sil24_reset_controller calls it to
kick the controller if the controller doesn't turn on PORT_CS_RDY
after reset is complete.

I don't know if this is necessary.  I was just trying to be on the
safe side.

-- 
tejun