Re: [PATCH 1/2] libata: Remove dependence on host_set->dev for SAS
From: Jeff Garzik <hidden>
Date: 2005-10-25 17:53:14
Also in:
linux-scsi
Brian King wrote:
quoted hunk ↗ jump to hunk
Remove some of the dependence on the host_set struct in preparation for supporting SAS HBAs. Adds a struct device pointer to the ata_port struct. This patch depends on the qc_transport patch: http://marc.theaimsgroup.com/?l=linux-ide&m=112845939215286&w=2 Signed-off-by: Brian King <brking@us.ibm.com> --- linux-2.6-bjking1/drivers/scsi/libata-core.c | 13 +++++++------ linux-2.6-bjking1/include/linux/libata.h | 1 + 2 files changed, 8 insertions(+), 6 deletions(-) diff -puN include/linux/libata.h~libata_host_set_dev include/linux/libata.h--- linux-2.6/include/linux/libata.h~libata_host_set_dev 2005-10-24 15:04:22.000000000 -0500 +++ linux-2.6-bjking1/include/linux/libata.h 2005-10-24 15:04:22.000000000 -0500@@ -315,6 +315,7 @@ struct ata_port { struct ata_host_stats stats; struct ata_host_set *host_set; + struct device *dev; struct work_struct packet_task;
Patch seems basically OK. But taking this patch to its conclusion means deleting 'dev' from struct ata_host_set too... I wonder what breakage will result from that? Jeff