Thread (20 messages) 20 messages, 4 authors, 2005-09-27
STALE7553d

[patch 4/4] ide: Break ide_lock -- remove ide_lock from piix driver

From: Ravikiran G Thirumalai <hidden>
Date: 2005-09-06 23:44:30
Also in: lkml

Patch to convert piix driver to use per-driver/hwgroup lock and kill
ide_lock.  In the case of piix, hwgroup->lock should be sufficient.

Signed-off-by: Ravikiran Thirumalai <redacted>

Index: linux-2.6.13/drivers/ide/pci/piix.c
===================================================================
--- linux-2.6.13.orig/drivers/ide/pci/piix.c	2005-09-06 12:00:25.000000000 -0700
+++ linux-2.6.13/drivers/ide/pci/piix.c	2005-09-06 13:22:49.000000000 -0700
@@ -231,7 +231,6 @@
 
 	pio = ide_get_best_pio_mode(drive, pio, 5, NULL);
 	spin_lock_irqsave(&hwgroup->lock, flags);
-	spin_lock(&ide_lock);
 	pci_read_config_word(dev, master_port, &master_data);
 	if (is_slave) {
 		master_data = master_data | 0x4000;
@@ -251,7 +250,6 @@
 	pci_write_config_word(dev, master_port, master_data);
 	if (is_slave)
 		pci_write_config_byte(dev, slave_port, slave_data);
-	spin_unlock(&ide_lock);
 	spin_unlock_irqrestore(&hwgroup->lock, flags);
 }
 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help