Mark Lord wrote:

Jeff Garzik wrote:

quoted

-#ifndef ATA_ENABLE_ATAPI
-    if (unlikely(dev->class == ATA_DEV_ATAPI))
-        return NULL;
-#endif
+    if (atapi_enabled) {
+        if (unlikely(dev->class == ATA_DEV_ATAPI))
+            return NULL;
+    }

..

Is that if-stmt the right way around?
At first glance, I'd expect it to read:

     if (!atapi_enabled) {
     ...

Cheers!

Indeed, thanks, fixed.

	Jeff