Re: Another libata TODO item

Christoph Hellwig wrote:

On Wed, Aug 24, 2005 at 02:17:11AM -0400, Jeff Garzik wrote:

quoted

To make libata debugging easier and more fine-grained, we should convert 
DPRINTK/VPRINTK calls in libata to code that looks like

if (ata_msg_xxx(ap->msg_enable))
	printk(...)

Would be nice if you could move that one up to the scsi layer and combine
it with the existing scsi core loglevel handling.

Doubtful.  libata's use of SCSI will become optional, so using SCSI 
logging throughout libata core would be inappropriate.  Block layer 
would be more reasonable.

In any case, I also contine to be skeptical of in-kernel logging subsystems.

	Jeff